From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3QUk-0007Sj-1Q for qemu-devel@nongnu.org; Mon, 20 Aug 2012 07:50:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3QUi-0004az-T4 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 07:50:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3QUi-0004aq-Lr for qemu-devel@nongnu.org; Mon, 20 Aug 2012 07:50:08 -0400 Message-ID: <5032246C.3050501@redhat.com> Date: Mon, 20 Aug 2012 13:50:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344338247-17567-1-git-send-email-pbonzini@redhat.com> <5026B21A.6000701@weilnetz.de> <502958D8.7020105@weilnetz.de> In-Reply-To: <502958D8.7020105@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulated AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: aliguori@linux.vnet.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 13/08/2012 21:43, Stefan Weil ha scritto: >> >> Label out_free_buf is only used with CONFIG_LINUX_AIO. >> >> off_t is always 32 bit with MinGW header files, but we >> want support for large files, so off64_t is a better choice >> here. It also avoids a compiler warning when the value >> is right shifted by 32 bits. Thanks, I squashed these in. >> I noticed some messages from checkpatch.pl. >> Some (but not all) of them were caused by the renamed file. >> Maybe this file should be fixed before it is renamed. If you make "git diff" detect renames they should go away. > More changes are needed for user mode emulation. > I hope they don't break linking of other executables: There's need for more cleanup here, indeed. qemu-ga is including a lot of unnecessary cruft via tools-obj-y (where it only needs tracing and oslib, basically). cutils.c/iov.c are unnecessarily intertwined and user mode emulation has no business including either. It should also not need event_notifier.c. Paolo