From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Qf5-0002uL-50 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 08:00:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Qf4-00080N-2r for qemu-devel@nongnu.org; Mon, 20 Aug 2012 08:00:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Qf3-00080I-RH for qemu-devel@nongnu.org; Mon, 20 Aug 2012 08:00:50 -0400 Message-ID: <503226E4.1050206@redhat.com> Date: Mon, 20 Aug 2012 14:00:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1344846917-7411-1-git-send-email-nab@linux-iscsi.org> <1344846917-7411-5-git-send-email-nab@linux-iscsi.org> <5031FD9E.9080204@redhat.com> <20120820115704.GA3580@redhat.com> In-Reply-To: <20120820115704.GA3580@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Hajnoczi , kvm-devel , Stefan Hajnoczi , qemu-devel , "Nicholas A. Bellinger" , Zhi Yong Wu , Anthony Liguori , target-devel , Jan Kiszka , lf-virt , Christoph Hellwig Il 20/08/2012 13:57, Michael S. Tsirkin ha scritto: >>> > > How much of the functionality of virtio-scsi.[ch] is still in use at >>> > > this point? Would it make more sense to use a separate vhost-scsi-pci >>> > > device instead? >> > >> > Since the SCSI target lives in the kernel, almost everything is driven >> > from tcm_vhost.ko. tcm_vhost.ko basically implements the full device >> > so I see the argument for -device vhost-scsi-pci. > A bit unhappy that there is no virtio in the name since it is > implementing virtio protocol. > Yeah, but vhost \subseteq virtio... Paolo