From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3RsN-0006nU-9m for qemu-devel@nongnu.org; Mon, 20 Aug 2012 09:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3RsJ-0001DK-73 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 09:18:39 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:62328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3RsI-0001DE-Vk for qemu-devel@nongnu.org; Mon, 20 Aug 2012 09:18:35 -0400 Received: by eeke53 with SMTP id e53so1657549eek.4 for ; Mon, 20 Aug 2012 06:18:33 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50323926.8000205@redhat.com> Date: Mon, 20 Aug 2012 15:18:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com> In-Reply-To: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cong Meng Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com, Rusty Russell , linuxram@us.ibm.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org Il 20/08/2012 11:03, Cong Meng ha scritto: > Each virtio scsi HBA has global request queue limits. But the passthrough > LUNs (scsi-generic) come from different host HBAs may have different request > queue limits. If the guest sends commands that exceed the host limits, the > commands will be rejected by host HAB. > > To address this issue, this patch adds a per-LUN parameter query via the control > queue, and defines some parameter query types. The driver can query and set the > needed per-LUN parameters if the device enables this feature. > > Signed-off-by: Cong Meng > -- > virtio-spec.lyx | 218 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 218 insertions(+), 0 deletions(-) Do you have kernel and QEMU patches for this? That would help me evaluate whether the interface is the correct one. In any case, I'd rather have a single command returning all three values (VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just one. Paolo