From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3UCT-0004w9-Gh for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:47:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3UCS-0005iK-8G for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:47:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3UCR-0005iA-VM for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:47:32 -0400 Message-ID: <50325C0D.1010108@redhat.com> Date: Mon, 20 Aug 2012 09:47:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345473098-26299-1-git-send-email-berrange@redhat.com> In-Reply-To: <1345473098-26299-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig1642FD77A46CB6B1E36AFEF1" Subject: [Qemu-devel] For 1.2: Re: [PATCH] qapi: add 'query-target' command to return target arch/bit size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1642FD77A46CB6B1E36AFEF1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/20/2012 08:31 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" >=20 > Add a 'query-target' QAPI command to allow management applications > to determine what target architecture a QEMU binary is emulating > without having to parse the binary name or -help output >=20 > $ qmp-shell -p /tmp/qemu > (QEMU) query-target > { u'return': { u'arch': u'x86_64', u'bits': 64}} >=20 > Signed-off-by: Daniel P. Berrange > --- > arch_init.c | 11 +++++++++++ > qapi-schema.json | 25 +++++++++++++++++++++++++ > qmp-commands.hx | 5 +++++ > 3 files changed, 41 insertions(+) Adding the for 1.2 marking in the subject, to make it clear that this is a "bug fix" for the fact that Anthony's QMP additions for libvirt were incomplete, and should be pulled in now rather than delayed to 1.3. > +## > +# @TargetInfo: > +# > +# Information describing the QEMU target. > +# > +# @arch: the name of the target architecture (eg "x86_64", "i686", etc= ) s/eg/e.g./ (it is an abbreviation of the two-word phrase exempli gratia) Or even better, since mixing 'e.g.' and 'etc.' in the same sentence sounds stupid, just go with the much simpler: @arch: the name of the target architecture (such as "x86_64" or "i686") > +# @bits: number of bits in physical address (eg 32 or 64) Ditto. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig1642FD77A46CB6B1E36AFEF1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQMlwNAAoJEKeha0olJ0Nq77sH/AuroMr/x4Zh08tmF/mGu6oU fdyKrzB51DDevSEAurD/ekRIWSwu/o+pd2VSj0Zjj+EwYFB+XZOxv4+BP64HA1UC g+RKPOO396NO6aGtovL4vhJNWE1o9iqL56stobfc2bbVK2TxYgzZEh7AqDhP8AH1 +oJKLhYeNcPnizjQaTtl03IgC+g0NxMpBpERvMAkoVctdU436WWQmHOD1P0XMxWi nCMkBMc0lGpI9ty+emyO4r6bzxKyVs94ydJzntE7y/87fa/XMZIfSC4uKOSIAY0M 0Ld2EejYqjkwJcV1GYfnM5WMa/9BIsAOKSPYDP0iawmSPXSnsswyLaDliHJFRR8= =nKdx -----END PGP SIGNATURE----- --------------enig1642FD77A46CB6B1E36AFEF1--