qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main
Date: Mon, 20 Aug 2012 20:11:36 +0200	[thread overview]
Message-ID: <50327DD8.8070205@siemens.com> (raw)

VCPUs are either resumed directly via vm_start, after the incoming
migration is done, or when a continue command is issued. We don't need
the explicit resume before entering main_loop.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

I was adding nesting support to pause/resume_all_vcpus, and that
stumbled over the imbalance below.

 vl.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/vl.c b/vl.c
index ebee867..231d3ab 100644
--- a/vl.c
+++ b/vl.c
@@ -3757,7 +3757,6 @@ int main(int argc, char **argv, char **envp)
 
     os_setup_post();
 
-    resume_all_vcpus();
     main_loop();
     bdrv_close_all();
     pause_all_vcpus();
-- 
1.7.3.4

             reply	other threads:[~2012-08-20 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 18:11 Jan Kiszka [this message]
2012-08-21  7:01 ` [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main Paolo Bonzini
2012-08-21  7:24   ` Jan Kiszka
2013-05-02 11:20   ` Jan Kiszka
2013-05-02 11:55     ` Andreas Färber
2013-05-02 12:06       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50327DD8.8070205@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).