From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3iSz-0002V0-Pl for qemu-devel@nongnu.org; Tue, 21 Aug 2012 03:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3iSv-0000kT-Mg for qemu-devel@nongnu.org; Tue, 21 Aug 2012 03:01:33 -0400 Received: from mail-gh0-f173.google.com ([209.85.160.173]:61314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3iSv-0000kP-IV for qemu-devel@nongnu.org; Tue, 21 Aug 2012 03:01:29 -0400 Received: by ghrr17 with SMTP id r17so5572317ghr.4 for ; Tue, 21 Aug 2012 00:01:29 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50333245.3060501@redhat.com> Date: Tue, 21 Aug 2012 09:01:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <50327DD8.8070205@siemens.com> In-Reply-To: <50327DD8.8070205@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel Il 20/08/2012 20:11, Jan Kiszka ha scritto: > VCPUs are either resumed directly via vm_start, after the incoming > migration is done, or when a continue command is issued. We don't need > the explicit resume before entering main_loop. > > Signed-off-by: Jan Kiszka > --- > > I was adding nesting support to pause/resume_all_vcpus, and that > stumbled over the imbalance below. > > vl.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index ebee867..231d3ab 100644 > --- a/vl.c > +++ b/vl.c > @@ -3757,7 +3757,6 @@ int main(int argc, char **argv, char **envp) > > os_setup_post(); > > - resume_all_vcpus(); > main_loop(); > bdrv_close_all(); > pause_all_vcpus(); > Makes sense. Do we need a "main loop and similar" tree, or can that tree be just uq/master now that qemu-kvm.c is dying? Paolo