From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lnI-0004L6-BD for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:34:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3lnC-0004wV-GT for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:34:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lnC-0004wR-8d for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:34:38 -0400 Message-ID: <5033643A.10805@redhat.com> Date: Tue, 21 Aug 2012 12:34:34 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1345544183-19192-1-git-send-email-alevy@redhat.com> <1345544183-19192-3-git-send-email-alevy@redhat.com> In-Reply-To: <1345544183-19192-3-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org On 08/21/12 12:16, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > This io calls the corresponding new spice api > spice_qxl_monitors_config_async to let spice-server read a new guest set > monitors config and notify the client. > > On migration reissue spice_qxl_monitors_config_async. Applying: qxl: add QXL_IO_MONITORS_CONFIG_ASYNC === checkpatch complains === ERROR: space prohibited before open square bracket '[' #198: FILE: hw/qxl.c:2116: + .fields = (VMStateField []) { ERROR: space prohibited before open square bracket '[' #211: FILE: hw/qxl.c:2148: + .subsections = (VMStateSubsection []) { total: 2 errors, 0 warnings, 231 lines checked