From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lsY-0007a2-Mc for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:40:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3lsX-0007TK-A7 for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:40:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lsX-0007Qd-2L for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:40:09 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7LAe7kD023823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Aug 2012 06:40:07 -0400 Message-ID: <50336596.5050106@redhat.com> Date: Tue, 21 Aug 2012 13:40:22 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1345288635-1369-1-git-send-email-quintela@redhat.com> <1345288635-1369-2-git-send-email-quintela@redhat.com> In-Reply-To: <1345288635-1369-2-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] buffered_file: g_realloc() can't fail List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 08/18/2012 02:17 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > buffered_file.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/buffered_file.c b/buffered_file.c > index f170aa0..4148abb 100644 > --- a/buffered_file.c > +++ b/buffered_file.c > @@ -50,20 +50,12 @@ static void buffered_append(QEMUFileBuffered *s, > const uint8_t *buf, size_t size) > { > if (size > (s->buffer_capacity - s->buffer_size)) { > - void *tmp; > - > DPRINTF("increasing buffer capacity from %zu by %zu\n", > s->buffer_capacity, size + 1024); > > s->buffer_capacity += size + 1024; > > - tmp = g_realloc(s->buffer, s->buffer_capacity); > - if (tmp == NULL) { > - fprintf(stderr, "qemu file buffer expansion failed\n"); > - exit(1); > - } > - > - s->buffer = tmp; > + s->buffer = g_realloc(s->buffer, s->buffer_capacity); > } > > memcpy(s->buffer + s->buffer_size, buf, size); > Reviewed-by: Orit Wasserman