From: Paolo Bonzini <pbonzini@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: report success-response field in guest-info
Date: Tue, 21 Aug 2012 13:56:38 +0200 [thread overview]
Message-ID: <50337776.5000308@redhat.com> (raw)
In-Reply-To: <dbb816bb3aadec3a3d3bb24a83c5444d977cdb41.1345544709.git.mprivozn@redhat.com>
Il 21/08/2012 12:25, Michal Privoznik ha scritto:
> +bool qmp_command_reports_success(const char *name) {
> + QmpCommand *cmd;
> +
> + QTAILQ_FOREACH(cmd, &qmp_commands, node) {
> + if (strcmp(cmd->name, name) == 0) {
> + return cmd->options ^ QCO_NO_SUCCESS_RESP;
Clever... but please use (a & b) == 0 instead...
Paolo
> + }
> + }
> +
> + return true;
> +}
> +
prev parent reply other threads:[~2012-08-21 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 10:25 [Qemu-devel] [PATCH] qemu-ga: report success-response field in guest-info Michal Privoznik
2012-08-21 11:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50337776.5000308@redhat.com \
--to=pbonzini@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).