From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33828)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T3n4k-0000ir-Jf
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 07:56:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T3n4e-0006Tl-01
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 07:56:50 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:52094)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T3n4d-0006Th-S7
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 07:56:43 -0400
Received: by yhpp34 with SMTP id p34so5643828yhp.4
	for <qemu-devel@nongnu.org>; Tue, 21 Aug 2012 04:56:43 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50337776.5000308@redhat.com>
Date: Tue, 21 Aug 2012 13:56:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <dbb816bb3aadec3a3d3bb24a83c5444d977cdb41.1345544709.git.mprivozn@redhat.com>
In-Reply-To: <dbb816bb3aadec3a3d3bb24a83c5444d977cdb41.1345544709.git.mprivozn@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: report success-response field in
	guest-info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org

Il 21/08/2012 12:25, Michal Privoznik ha scritto:
> +bool qmp_command_reports_success(const char *name) {
> +    QmpCommand *cmd;
> +
> +    QTAILQ_FOREACH(cmd, &qmp_commands, node) {
> +        if (strcmp(cmd->name, name) == 0) {
> +            return cmd->options ^ QCO_NO_SUCCESS_RESP;

Clever... but please use (a & b) == 0 instead...

Paolo

> +        }
> +    }
> +
> +    return true;
> +}
> +