From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3nOM-0006PQ-RO for qemu-devel@nongnu.org; Tue, 21 Aug 2012 08:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3nOL-0003uo-Jr for qemu-devel@nongnu.org; Tue, 21 Aug 2012 08:17:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3nOL-0003uk-Aa for qemu-devel@nongnu.org; Tue, 21 Aug 2012 08:17:05 -0400 Message-ID: <50337C3D.7020705@redhat.com> Date: Tue, 21 Aug 2012 06:17:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <8775b5191231ab92d04a18efa43cc2ef076bd73c.1345550503.git.mprivozn@redhat.com> In-Reply-To: <8775b5191231ab92d04a18efa43cc2ef076bd73c.1345550503.git.mprivozn@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2167368973AC2CCAD5EAD786" Subject: [Qemu-devel] For 1.2: Re: [PATCH v2] qemu-ga: report success-response field in guest-info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2167368973AC2CCAD5EAD786 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/21/2012 06:03 AM, Michal Privoznik wrote: > This is a useful hint for users (or libvirt) whether a command returns > anything success and hence wait for reply or not. > --- > diff to v1: > -changed condition in qmp_command_reports_success per Paolo's advice >=20 > qapi-schema-guest.json | 6 +++++- > qapi/qmp-core.h | 1 + > qapi/qmp-registry.c | 12 ++++++++++++ > qga/commands.c | 1 + > 4 files changed, 19 insertions(+), 1 deletions(-) Adding 'For 1.2', on the grounds that we changed semantics in 1.2 (1.1 didn't have any commands with success-response marking to begin with), and therefore it is a usability bug if we don't fix it in time for this release. >=20 > diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json > index d955cf1..2cd5957 100644 > --- a/qapi-schema-guest.json > +++ b/qapi-schema-guest.json > @@ -91,10 +91,14 @@ > # > # @enabled: whether command is currently enabled by guest admin > # > +# @success-response: whether command report success response or not. > +# See 'uest-shutdown' command for more detailed inf= o. s/uest/guest/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2167368973AC2CCAD5EAD786 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQM3w+AAoJEKeha0olJ0NqeLUH/1T1/d3i3+eVDtse74LhIUMC FFA2v2I/1m9KwKQlvXD4ru50G7vibafPXa0w5h/lGqGprPd/hHMYcxRpAEl8vHgO q3byr7+HSymdRA8yp6ZvXu+QkzciJy/iB68y8wuVCd3qYSu4g1DFveZ+vNydEQfl 8AcdIKOWC3xxKaBf0d/UBZqBFM4115XJSLxKLzdC/tVvI0MfLhZICv0Y3oLJu/Zy AaU299N9gsZMxxtpEE5HLAuhTTtKk+4KIE659EevHWzjuOPW5S+pYBT5j6V0tLjh HvOJ9uOqwMIs89v9S9fi3t6OcbJnkkj0XK1Ht3smsEBbmZIo0UR4oAQFksmOaQQ= =L/Of -----END PGP SIGNATURE----- --------------enig2167368973AC2CCAD5EAD786--