From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T3nnw-0006mm-B5
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 08:43:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T3nnp-0004Ga-ED
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 08:43:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21775)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T3nnp-0004G2-76
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 08:43:25 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7LChOuW027150
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 21 Aug 2012 08:43:24 -0400
Message-ID: <5033826A.8020209@redhat.com>
Date: Tue, 21 Aug 2012 14:43:22 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1345546294-22144-1-git-send-email-alevy@redhat.com>
	<1345546294-22144-3-git-send-email-alevy@redhat.com>
	<50336BB7.2010705@redhat.com>
In-Reply-To: <50336BB7.2010705@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v11 3/4] qxl: add
	QXL_IO_MONITORS_CONFIG_ASYNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/21/12 13:06, Gerd Hoffmann wrote:
> On 08/21/12 12:51, Alon Levy wrote:
>> Revision bumped to 4 for new IO support, enabled for spice-server >=3D
>> 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, an=
d
>> defaults to 4, iff spice-server >=3D 0.11.1 && spice-protocol >=3D
>> 0.12.0.
>=20
> All four patches added to spice patch queue.

Spoke too soon, it fails the build with old spice-server:

  CC    i386-softmmu/hw/i386/../qxl.o
/var/lib/buildbot/slaves/spunk/ubuntu-default/build/hw/i386/../qxl.c: In
function =91qxl_post_load=92:
/var/lib/buildbot/slaves/spunk/ubuntu-default/build/hw/i386/../qxl.c:2055=
:13:
warning: implicit declaration of function
=91spice_qxl_monitors_config_async=92 [-Wimplicit-function-declaration]
/var/lib/buildbot/slaves/spunk/ubuntu-default/build/hw/i386/../qxl.c:2055=
:13:
warning: nested extern declaration of =91spice_qxl_monitors_config_async=92
[-Wnested-externs]
  CC    i386-softmmu/hw/i386/../qxl-logger.o
[ ... ]
  LINK  i386-softmmu/qemu-system-i386
hw/i386/../qxl.o: In function `qxl_post_load':
qxl.c:(.text+0x3505): undefined reference to
`spice_qxl_monitors_config_async'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-i386] Error 1

cheers,
  Gerd