From: Paolo Bonzini <pbonzini@redhat.com>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: Avi Kivity <avi@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] ivshmem assertion failure with EventNotifier
Date: Wed, 22 Aug 2012 14:01:33 +0200 [thread overview]
Message-ID: <5034CA1D.80101@redhat.com> (raw)
In-Reply-To: <CAKjmthLA0fUJ29ov4EqVHbC+fuYtOzxgWX5r+s_G-sJGpWYGGg@mail.gmail.com>
Il 22/08/2012 06:29, Cam Macdonell ha scritto:
> Hi Paolo,
>
> I've noticed an assertion error when sending interrupts via ivshmem.
> I bisected to this patch.
Does this help?
diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index b4d65a6..47f2a16 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -366,6 +366,10 @@ static void close_guest_eventfds(IVShmemState *s,
int posn)
{
int i, guest_curr_max;
+ if (!ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
+ return;
+ }
+
guest_curr_max = s->peers[posn].nb_eventfds;
memory_region_transaction_begin();
Paolo
next prev parent reply other threads:[~2012-08-22 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 4:29 [Qemu-devel] ivshmem assertion failure with EventNotifier Cam Macdonell
2012-08-22 8:05 ` Jan Kiszka
2012-08-22 12:01 ` Paolo Bonzini [this message]
2012-08-22 17:00 ` Cam Macdonell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5034CA1D.80101@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).