From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T49cv-00072Z-Ti
	for qemu-devel@nongnu.org; Wed, 22 Aug 2012 08:01:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T49cu-0006Ac-Qo
	for qemu-devel@nongnu.org; Wed, 22 Aug 2012 08:01:37 -0400
Received: from mail-ee0-f45.google.com ([74.125.83.45]:47150)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T49cu-0006AR-KL
	for qemu-devel@nongnu.org; Wed, 22 Aug 2012 08:01:36 -0400
Received: by eeke53 with SMTP id e53so291885eek.4
	for <qemu-devel@nongnu.org>; Wed, 22 Aug 2012 05:01:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5034CA1D.80101@redhat.com>
Date: Wed, 22 Aug 2012 14:01:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAKjmthLA0fUJ29ov4EqVHbC+fuYtOzxgWX5r+s_G-sJGpWYGGg@mail.gmail.com>
In-Reply-To: <CAKjmthLA0fUJ29ov4EqVHbC+fuYtOzxgWX5r+s_G-sJGpWYGGg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] ivshmem assertion failure with EventNotifier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: Avi Kivity <avi@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Il 22/08/2012 06:29, Cam Macdonell ha scritto:
> Hi Paolo,
> 
> I've noticed an assertion error when sending interrupts via ivshmem.
> I bisected to this patch.

Does this help?

diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index b4d65a6..47f2a16 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -366,6 +366,10 @@ static void close_guest_eventfds(IVShmemState *s,
int posn)
 {
     int i, guest_curr_max;

+    if (!ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) {
+        return;
+    }
+
     guest_curr_max = s->peers[posn].nb_eventfds;

     memory_region_transaction_begin();

Paolo