From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: aliguori@us.ibm.com, Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org, David Gibson <dwg@au1.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates
Date: Wed, 22 Aug 2012 16:09:35 +0300 [thread overview]
Message-ID: <5034DA0F.1070609@redhat.com> (raw)
In-Reply-To: <6BD8D076-FCD4-48B4-969A-CB6E3E27D280@suse.de>
On 08/22/2012 02:47 PM, Alexander Graf wrote:
>>
>> Ok, so IIUC, that means we do need the cpu_physical_memory_write_rom()
>> version for load_image_targphys(), and so my original patch is
>> basically the right fix.
>
> Sure it is, I don't think anyone argued about that :). But it's duplicating code in a slow path. So my proposal was instead of doing the write manually in the "this is read-write RAM" case, just fall back to the known-to-work cpu_physical_memory_rw for those pages. That would make the rom function smaller, more obvious and duplicate less code.
I think there were patches (from Xen) extracting that snippet into a helper.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-22 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 4:59 [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates David Gibson
2012-08-22 5:55 ` Alexander Graf
2012-08-22 5:57 ` David Gibson
2012-08-22 6:02 ` Alexander Graf
2012-08-22 6:10 ` David Gibson
2012-08-22 6:12 ` Alexander Graf
2012-08-22 6:31 ` Alexander Graf
2012-08-22 6:47 ` Jan Kiszka
2012-08-22 7:05 ` Jan Kiszka
2012-08-22 11:38 ` David Gibson
2012-08-22 11:47 ` Alexander Graf
2012-08-22 13:09 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-03 0:58 David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5034DA0F.1070609@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=dwg@au1.ibm.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).