From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4CEg-0007ol-6O for qemu-devel@nongnu.org; Wed, 22 Aug 2012 10:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4CEa-0007dZ-Co for qemu-devel@nongnu.org; Wed, 22 Aug 2012 10:48:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4CEa-0007dS-3k for qemu-devel@nongnu.org; Wed, 22 Aug 2012 10:48:40 -0400 Message-ID: <5034F144.3060101@redhat.com> Date: Wed, 22 Aug 2012 08:48:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345288635-1369-1-git-send-email-quintela@redhat.com> <1345288635-1369-4-git-send-email-quintela@redhat.com> <502F927A.8060709@redhat.com> <87wr0rgiyc.fsf@codemonkey.ws> In-Reply-To: <87wr0rgiyc.fsf@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5CA4C713A74C2693F32CC5E0" Subject: Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5CA4C713A74C2693F32CC5E0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 08/22/2012 07:22 AM, Anthony Liguori wrote: Just restating things to make sure I'm clear... >>> { 'type': 'MigrationInfo', >>> 'data': {'*status': 'str', '*ram': 'MigrationStats', >>> '*disk': 'MigrationStats', >>> - '*xbzrle-cache': 'XBZRLECacheStats'} } >>> + '*xbzrle-cache': 'XBZRLECacheStats', >>> + 'total-time': 'int'} } >> >> Anthony - are you planning on taking this series for 1.2? >=20 > No. This is a new feature and we're past freeze. No, the overall series (patches 1,2,4-8) is not appropriate at this time.= >=20 >> If we don't >> get this patch in on time, then taking this for 1.3 would result in >> changing released QMP interface (right now, there has been no release >> with the field in the wrong type). >=20 > Ack. We need to preserve compat with the 1.2 interface. Yes, this particular patch 3 is a bug fix in order to prevent a future regression when 1.3 takes the rest of the series, and must therefore be part of the 1.2 release (and Luiz is on top of that, via the qmp branch).= --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5CA4C713A74C2693F32CC5E0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQNPFFAAoJEKeha0olJ0NqBQMH/308ZRrlsIgWrFxC1M1vR/KZ CSm3oCiYByfMlDIL3imw1sn9rGE6cFqempTPPwNy5SwaHOm0FglpfiDC4sMACxqv ozoIi19IIjHgJLVV8gOkcqOJhLBkJgvzCXcj44t2PWLdGtgd7pacwgeXaIvmfcp3 RQGzMYFRdrGlccET+M5Lric0dmZWbTTNVJThbLgHwcROPsLkm16aKI2Yblf4oAcr tVx4sK/Shp2+DvS0zvqQTuVkHhJ9IFH/jvMd5G/X1MQ4lVK+iT9sg3HR1Ngzbhva mDnVOHlIgRNMyIS1WbtAS/6Vlk8e5pKxhHJnyo4ZLgm/JO262hNoATkcJMcP+Ps= =FfPT -----END PGP SIGNATURE----- --------------enig5CA4C713A74C2693F32CC5E0--