From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1T4D7C-0002fM-K4
	for qemu-devel@nongnu.org; Wed, 22 Aug 2012 11:45:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1T4D78-0000aa-Dq
	for qemu-devel@nongnu.org; Wed, 22 Aug 2012 11:45:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1T4D78-0000W3-5e
	for qemu-devel@nongnu.org; Wed, 22 Aug 2012 11:45:02 -0400
Message-ID: <5034FE7A.8030008@redhat.com>
Date: Wed, 22 Aug 2012 09:44:58 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1345648178-19823-1-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1345648178-19823-1-git-send-email-aliguori@us.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enig7B634591916E77A6C2B42286"
Subject: Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return
 target arch/bit size (v2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig7B634591916E77A6C2B42286
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 08/22/2012 09:09 AM, Anthony Liguori wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>=20
> Add a 'query-target' QAPI command to allow management applications
> to determine what target architecture a QEMU binary is emulating
> without having to parse the binary name or -help output
>=20
>   $ qmp-shell -p /tmp/qemu
>   (QEMU) query-target
>   {   u'return': {   u'arch': u'x86_64' }}
>=20
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---

> +
> +##
> +# @TargetInfo:
> +#
> +# Information describing the QEMU target.
> +#
> +# @arch: the target architecture (eg "x86_64", "i386", etc)

Missed my v1 comment that 'eg' is misspelled (would be 'e.g.'), and with
my recommendation for an alternate wording:

@arch: the target architecture (such as "x86_64" or "i686")

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig7B634591916E77A6C2B42286
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJQNP57AAoJEKeha0olJ0NqGUYH/AhcNPXEbZZUEkoquB9hFc0f
48B8Q7mss10NMaKTIQjZsjW/TwAS/tWn6jU+PyOki3UQo5iODgU1bhTXsMM8Yk5A
05PwP89l1LbWaslK+5yMDVRYorLPAmXqCdPck3LCyAPEPtsHoFMVYU++u5Z7GDLC
b8uM7jlQn3aW+QCdC1N39XJL8+pCCf/NWuDhPNZ8tr8IiTB1BHUBn3+Xfb/0BC5a
cqXS2nkTj96d5HaGpojGTlt28Hfi1IlhwhB/7MfkIbItKcFxmwAG+0ExcjpuKFUZ
k1bYALaV+o9FY1extS8khwH5UT3h6dqWNYrPfx9FN4/TyXibALUUE7WjeuxCJ3k=
=yc/Z
-----END PGP SIGNATURE-----

--------------enig7B634591916E77A6C2B42286--