From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4EA0-000280-2F for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4E9u-0001RO-BO for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:52:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47042 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4E9u-0001RF-50 for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:51:58 -0400 Message-ID: <50350E2A.2000209@suse.de> Date: Wed, 22 Aug 2012 18:51:54 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1320925122-4422-1-git-send-email-jcmvbkbc@gmail.com> <4EBD7B77.6040904@codemonkey.ws> In-Reply-To: <4EBD7B77.6040904@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori , Bruce Rogers Am 11.11.2011 20:45, schrieb Anthony Liguori: > On 11/10/2011 05:38 AM, Max Filippov wrote: >> With -icount, The vm_clock is updated with help from TCG (it counts >> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction >> count is not available so KVM cannot provide this help. >> >> Signed-off-by: Max Filippov >> Acked-by: Paolo Bonzini >=20 > Applied. Thanks. Applied to stable-0.15. Thanks, Andreas > Regards, >=20 > Anthony Liguori >=20 >> --- >> v1 -> v2 changes: >> - cover both kvm and xen; >> - add explanation text. >> --- >> vl.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index f169aac..bb601e2 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp) >> fprintf(stderr, "could not initialize alarm timer\n"); >> exit(1); >> } >> + >> + if (icount_option&& (kvm_enabled() || xen_enabled())) { >> + fprintf(stderr, "-icount is not allowed with kvm or xen\n"); >> + exit(1); >> + } >> configure_icount(icount_option); >> >> if (net_init_clients()< 0) { --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg