From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4ECq-0004Oj-Ba for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4ECo-0002iS-TS for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:55:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47141 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4ECo-0002iF-Jw for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:54:58 -0400 Message-ID: <50350EE0.50503@suse.de> Date: Wed, 22 Aug 2012 18:54:56 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4F2C17AE.3040507@codemonkey.ws> In-Reply-To: <4F2C17AE.3040507@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger Cc: qemu-devel@nongnu.org, Anthony Liguori Am 03.02.2012 18:21, schrieb Anthony Liguori: > On 01/25/2012 02:04 PM, Gerhard Wiesinger wrote: >> Bugfix after reboot when vmmouse was enabled and another OS which uses >> e.g. PS/2 >> mouse. >> >> Details: >> When a guest activated the vmmouse followed by a reboot the vmmouse >> was still >> enabled and the PS/2 mouse was therefore unsusable. When another guest >> is then >> booted without vmmouse support (e.g. PS/2 mouse) the mouse is not >> working. >> >> Reason is that VMMouse has priority and disables all other mouse entit= ies >> and therefore must be disabled on reset. >> >> Testscenario: >> 1.) Boot e.g. OS with VMMouse support (e.g. Windows with VMMouse tools= ) >> 2.) reboot >> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) =3D> PS/2 mouse >> doesn't work >> any more. Fixes that issue. >> >> Testscenario 2 by Jan Kiszka : >> Confirm that this patch fixes a real issue. Setup: qemu.git, >> opensuse 11.4 guest, SDL graphic, system_reset while guest is using th= e >> vmmouse. Without the patch, the vmmouse become unusable after the >> reboot. Also, the mouse stays in absolute mode even before X starts >> again. >> >> Fixed by: >> Disabling the vmmouse in its reset handler. >> >> Signed-off-by: Gerhard Wiesinger >=20 > Applied. Thanks. Applied to stable-0.15. Thanks again, Andreas > Regards, >=20 > Anthony Liguori >=20 >> --- >> hw/vmmouse.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/hw/vmmouse.c b/hw/vmmouse.c >> index 1113f33..f9f5b53 100644 >> --- a/hw/vmmouse.c >> +++ b/hw/vmmouse.c >> @@ -254,6 +254,8 @@ static void vmmouse_reset(DeviceState *d) >> >> s->status =3D 0xffff; >> s->queue_size =3D VMMOUSE_QUEUE_SIZE; >> + >> + vmmouse_disable(s); >> } >> >> static int vmmouse_initfn(ISADevice *dev) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg