From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Hue-0005v4-Jt for qemu-devel@nongnu.org; Wed, 22 Aug 2012 16:52:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4HuY-0004jm-Si for qemu-devel@nongnu.org; Wed, 22 Aug 2012 16:52:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4HuY-0004jf-KY for qemu-devel@nongnu.org; Wed, 22 Aug 2012 16:52:22 -0400 Message-ID: <50354683.8070809@redhat.com> Date: Wed, 22 Aug 2012 14:52:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345667067-24298-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1345667067-24298-1-git-send-email-aliguori@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig1616F870BB85550DFE51AF37" Subject: Re: [Qemu-devel] [PATCH] boards: add a 'none' machine type to all platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1616F870BB85550DFE51AF37 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/22/2012 02:24 PM, Anthony Liguori wrote: > This allows any QEMU binary to be executed with: >=20 > $QEMU_BINARY -qmp stdio Don't you mean: $QEMU_BINARY -M none -qmp stdio I agree with including this in 1.2, as otherwise your new query-target and other commands are incomplete (that is, this is a 'bug fix' of rounding out a feature already promised at hard freeze, and not a new feature on its own). > +static QEMUMachine machine_none =3D { > + .name =3D "none", > + .desc =3D "empty machine", > + .init =3D machine_none_init, > + .max_cpus =3D 0, > +}; I guess libvirt just blindly tries '-S -M none'; if it works, we must be talking to new enough qemu (and all the other QMP commands that we want to probe are then immediately available); if it doesn't work, then we must be talking to older qemu and can fall back to -help scraping (since older versions won't be further modifying their -help output now that they are released). I like the idea, although I'm not familiar enough with this part of the code to know if my review counts for anything: Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig1616F870BB85550DFE51AF37 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQNUaEAAoJEKeha0olJ0NqSmEH/0oY88gOq3D0E4LmE+MEmrSp m4atpbq1ocht/8lhEFrSKrLwZRePoQ5/5EknG+OQqUwvyZOfqtIb4QAsvLQPkoyL e/qHWtzElI2++XrLQrroFPI+q65/XX/lDmfx+2NTtfC0hs5z7EF9igbrqtsxYVI2 fg41c5ViM0AgijQd21rNpY09Xm7tH9jngrb/tkk2FWj1KzyfnSz+9XiE/Swh7Da0 HqKO3b9B7Mgm5T90zCIjVVCFYxOlc9YSiUA8Q9eKqBNj4PW0Q8uPPf0E66419ibl LklENRuSH8abEpSWnWMXFE7l0h/kMW3hUsqPb5mh5jfhxSLTFPNrq+7pA2ZRFrY= =mo6s -----END PGP SIGNATURE----- --------------enig1616F870BB85550DFE51AF37--