From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4QBu-0006ib-Ov for qemu-devel@nongnu.org; Thu, 23 Aug 2012 01:42:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4QBt-0000GU-Fi for qemu-devel@nongnu.org; Thu, 23 Aug 2012 01:42:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4QBt-0000GH-7O for qemu-devel@nongnu.org; Thu, 23 Aug 2012 01:42:49 -0400 Message-ID: <5035C2D3.2090002@redhat.com> Date: Wed, 22 Aug 2012 23:42:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345698866-19794-1-git-send-email-lilei@linux.vnet.ibm.com> <1345698866-19794-4-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1345698866-19794-4-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE87E79CD105C29C27DF95AE0" Subject: Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE87E79CD105C29C27DF95AE0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/22/2012 11:14 PM, Lei Li wrote: > Signed-off-by: Lei Li Subject line uses '_', but the QMP command uses '-' [1] > --- > hmp-commands.hx | 16 ++++++++++++++++ > hmp.c | 15 +++++++++++++++ > hmp.h | 1 + > qapi-schema.json | 28 ++++++++++++++++++++++++++++ > qemu-char.c | 36 ++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 33 +++++++++++++++++++++++++++++++++ > 6 files changed, 129 insertions(+), 0 deletions(-) >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index f6104b0..829aea1 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -797,6 +797,22 @@ Inject an NMI on the given CPU (x86 only). > ETEXI > =20 > { > + .name =3D "memchar-write", HMP commands should use '_', not '-'. > +++ b/qapi-schema.json > @@ -235,6 +235,34 @@ > ## > { 'command': 'query-chardev', 'returns': ['ChardevInfo'] } > =20 > +{ 'enum': 'DataFormat' > + 'data': [ 'utf8', 'base64' ] } Missing documentation for DataFormat (see for example how @ErrorClass is documented). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE87E79CD105C29C27DF95AE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQNcLUAAoJEKeha0olJ0NqSiUIAKGc+dKiR8+8Apn1s2oekMZA 7O0Id6Yg4knB+nVhAeGDLKUt8TUBBta4Tj+3EEeUoDTwNNa5cegfsa5Lpx2cMIdD yuUTS6UTU/Y3soiN6upSP0fo/+S5CDdnBAPDAPGavRFall93chFl4ZEKOiqJFx/F RO30myGyBxCnWcSeFvo0m3ZClyb318c4zKEQ31gZzKoJgX9pst8pE2QAC4cKFRpt 9VQQHHp8b+g4JlzUqnpp389pbHOs3SIAkLP5Dg6HATVHsTmk3ApmlzaN5umsYH5d KGerNGubxHX5SGxfDzvppBFss/dRUFF+FOiyyvXBeTBreAF4Woss1VHjp5UUvVk= =tuQ9 -----END PGP SIGNATURE----- --------------enigE87E79CD105C29C27DF95AE0--