From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4R6l-0000bz-Fj for qemu-devel@nongnu.org; Thu, 23 Aug 2012 02:41:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4R6g-0008Io-9b for qemu-devel@nongnu.org; Thu, 23 Aug 2012 02:41:35 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:48179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4R6e-0008IW-TD for qemu-devel@nongnu.org; Thu, 23 Aug 2012 02:41:30 -0400 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Aug 2012 12:11:25 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7N6fNk16488490 for ; Thu, 23 Aug 2012 12:11:23 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7N6fNvs003537 for ; Thu, 23 Aug 2012 16:41:23 +1000 Message-ID: <5035D07B.6050701@linux.vnet.ibm.com> Date: Thu, 23 Aug 2012 14:40:59 +0800 From: Lei Li MIME-Version: 1.0 References: <1345698866-19794-1-git-send-email-lilei@linux.vnet.ibm.com> <1345698866-19794-4-git-send-email-lilei@linux.vnet.ibm.com> <5035C2D3.2090002@redhat.com> In-Reply-To: <5035C2D3.2090002@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 08/23/2012 01:42 PM, Eric Blake wrote: > On 08/22/2012 11:14 PM, Lei Li wrote: >> Signed-off-by: Lei Li > Subject line uses '_', but the QMP command uses '-' [1] > >> --- >> hmp-commands.hx | 16 ++++++++++++++++ >> hmp.c | 15 +++++++++++++++ >> hmp.h | 1 + >> qapi-schema.json | 28 ++++++++++++++++++++++++++++ >> qemu-char.c | 36 ++++++++++++++++++++++++++++++++++++ >> qmp-commands.hx | 33 +++++++++++++++++++++++++++++++++ >> 6 files changed, 129 insertions(+), 0 deletions(-) >> >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index f6104b0..829aea1 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -797,6 +797,22 @@ Inject an NMI on the given CPU (x86 only). >> ETEXI >> >> { >> + .name = "memchar-write", > HMP commands should use '_', not '-'. > >> +++ b/qapi-schema.json >> @@ -235,6 +235,34 @@ >> ## >> { 'command': 'query-chardev', 'returns': ['ChardevInfo'] } >> >> +{ 'enum': 'DataFormat' >> + 'data': [ 'utf8', 'base64' ] } > Missing documentation for DataFormat (see for example how @ErrorClass is > documented). > Sure, I will look into it and add documentation in v3, thanks! -- Lei