From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Vla-0007hu-0i for qemu-devel@nongnu.org; Thu, 23 Aug 2012 07:40:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4VlY-0001Ap-P5 for qemu-devel@nongnu.org; Thu, 23 Aug 2012 07:40:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4VlY-0001Ai-HW for qemu-devel@nongnu.org; Thu, 23 Aug 2012 07:40:00 -0400 Message-ID: <5036168B.1000900@redhat.com> Date: Thu, 23 Aug 2012 13:39:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <503612B9.1070601@siemens.com> In-Reply-To: <503612B9.1070601@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH] qemu-timer: Run timers in alarm timer handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Stefan Weil , qemu-devel Il 23/08/2012 13:23, Jan Kiszka ha scritto: > No need for this indirection via qemu_notify_event. On Unix, we already > catch SIGALRM via signalfd (or its emulation) and run the handler > synchronously. Under Win32, handlers run in separate threads. So we just > need to grab the global lock around the handler execution. > > Signed-off-by: Jan Kiszka > --- > > The Unix side looks safe to me, but I'm not yet 100% confident about > Win32. This is part of an ongoing effort to create separate alarm > timers over their own io-threads. A lengthy effort. Can you expand on this? The Win32 bits look fine, but it's a bit scary to make the Unix and Win32 paths so different. It works well until we have a BQL for timers, but would this complicate shrinking the scope of the BQL? Paolo