From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Vvv-0002Ou-9G for qemu-devel@nongnu.org; Thu, 23 Aug 2012 07:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4Vvr-0004ge-75 for qemu-devel@nongnu.org; Thu, 23 Aug 2012 07:50:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57377 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Vvq-0004fV-SS for qemu-devel@nongnu.org; Thu, 23 Aug 2012 07:50:39 -0400 Message-ID: <5036190A.7000705@suse.de> Date: Thu, 23 Aug 2012 13:50:34 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1345703083-25322-1-git-send-email-mmogilvi_qemu@miniinfo.net> <1345703083-25322-2-git-send-email-mmogilvi_qemu@miniinfo.net> In-Reply-To: <1345703083-25322-2-git-send-email-mmogilvi_qemu@miniinfo.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/6] fix some debug printf format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Ogilvie Cc: qemu-devel@nongnu.org Hi, Am 23.08.2012 08:24, schrieb Matthew Ogilvie: > These are normally ifdefed out and don't matter. But if you enable > them, they ought to be correct. >=20 > Signed-off-by: Matthew Ogilvie > --- >=20 > This version of the patch adds i8259.c. >=20 > An alternative approach might be to eliminate these printf's, > and/or replace them with trace*() calls, but until someone gets > around to doing so... >=20 > hw/cirrus_vga.c | 4 ++-- > hw/i8259.c | 3 ++- > hw/ide/cmd646.c | 5 +++-- > hw/ide/via.c | 5 +++-- > 4 files changed, 10 insertions(+), 7 deletions(-) >=20 > diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c > index e8dcc6b..909899d 100644 > --- a/hw/cirrus_vga.c > +++ b/hw/cirrus_vga.c > @@ -2055,8 +2055,8 @@ static void cirrus_vga_mem_write(void *opaque, > } > } else { > #ifdef DEBUG_CIRRUS > - printf("cirrus: mem_writeb " TARGET_FMT_plx " value %02x\n", a= ddr, > - mem_value); > + printf("cirrus: mem_writeb " TARGET_FMT_plx " value %" PRIx64 = "\n", > + addr, mem_value); This one is dropping 02. The other ones looks okay on brief look (declaration of "value" invisible= ). Regards, Andreas > #endif > } > } > diff --git a/hw/i8259.c b/hw/i8259.c > index 53daf78..6587666 100644 > --- a/hw/i8259.c > +++ b/hw/i8259.c > @@ -355,7 +355,8 @@ static uint64_t pic_ioport_read(void *opaque, targe= t_phys_addr_t addr, > ret =3D s->imr; > } > } > - DPRINTF("read: addr=3D0x%02x val=3D0x%02x\n", addr, ret); > + DPRINTF("read: addr=3D0x%02" TARGET_PRIxPHYS " val=3D0x%02x\n", > + addr, ret); > return ret; > } > =20 > diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c > index e0b9443..dd2855e 100644 > --- a/hw/ide/cmd646.c > +++ b/hw/ide/cmd646.c > @@ -154,7 +154,7 @@ static uint64_t bmdma_read(void *opaque, target_phy= s_addr_t addr, > break; > } > #ifdef DEBUG_IDE > - printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val); > + printf("bmdma: readb 0x%02" TARGET_PRIxPHYS " : 0x%02x\n", addr, v= al); > #endif > return val; > } > @@ -170,7 +170,8 @@ static void bmdma_write(void *opaque, target_phys_a= ddr_t addr, > } > =20 > #ifdef DEBUG_IDE > - printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val); > + printf("bmdma: writeb 0x%02" TARGET_PRIxPHYS " : 0x%02" PRIx64 "\n= ", > + addr, val); > #endif > switch(addr & 3) { > case 0: > diff --git a/hw/ide/via.c b/hw/ide/via.c > index b20e4f0..948a469 100644 > --- a/hw/ide/via.c > +++ b/hw/ide/via.c > @@ -55,7 +55,7 @@ static uint64_t bmdma_read(void *opaque, target_phys_= addr_t addr, > break; > } > #ifdef DEBUG_IDE > - printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val); > + printf("bmdma: readb 0x%02" TARGET_PRIxPHYS " : 0x%02x\n", addr, v= al); > #endif > return val; > } > @@ -70,7 +70,8 @@ static void bmdma_write(void *opaque, target_phys_add= r_t addr, > } > =20 > #ifdef DEBUG_IDE > - printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val); > + printf("bmdma: writeb 0x%02" TARGET_PRIxPHYS " : 0x%02" PRIx64 "\n= ", > + addr, val); > #endif > switch (addr & 3) { > case 0: >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg