From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4ek3-00037Q-Vo for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4ek2-0003eH-JX for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:15:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4ek2-0003b6-A0 for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:15:02 -0400 Message-ID: <50369D4B.2060508@redhat.com> Date: Thu, 23 Aug 2012 15:14:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1345725761-30680-1-git-send-email-benoit@irqsave.net> <1345725761-30680-3-git-send-email-benoit@irqsave.net> In-Reply-To: <1345725761-30680-3-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig1162673287C7F52572E1CE62" Subject: Re: [Qemu-devel] [PATCH V5 2/2] qemu-img: Add json output option to the info command. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com, =?UTF-8?B?QmVub8OudCBDYW5l?= =?UTF-8?B?dA==?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1162673287C7F52572E1CE62 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/23/2012 06:42 AM, Beno=C3=AEt Canet wrote: > This option --output=3D[human|json] make qemu-img info output on > human or JSON representation at the choice of the user. >=20 > +static int img_info(int argc, char **argv) > +{ > + int c; > + bool human =3D false, json =3D false; I'm still not convinced why we need two booleans, when one would do. If we ever add a third output type, it would be better to use an enum (0, 1, 2), rather than three separate bools. > =20 > +#undef PRINTH > + Where did this come from? Other than that, the rest of the series seems okay for 1.3 from my viewpoint. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig1162673287C7F52572E1CE62 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQNp1MAAoJEKeha0olJ0NqerYIAK+JNOybaYa6avBF0LjluLEp N2KdJEfdBHVcrLZPskShDmq8XQgwHeGXNqmph6bPunTvvgIDWY8Xsy/j8ARxOV4M UDzoO/ZJ2VJ9GM8U42KubNGK6aZ66j6i3P8SiFssup1kad3ZpslEDAQuqU2mGU98 G1/Sy1ArjZf4FBLzJJqmS9i0kCymcB8GC9X+tqvUt1p+ueHmev6H7IzHszKWDHIq yCsDnUnDszwyIQYCapDtYv/P5o9KVz7pwMKXur3cczDEYOUyytCl1SYwgg6W4Sba yIZlzlNK3x+L8K7CF+dWT1oMGGeERhtA1Z6XqmOrSyWm8/5pKjwtBMaxEEWUU+E= =nms7 -----END PGP SIGNATURE----- --------------enig1162673287C7F52572E1CE62--