From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4p4f-0007bf-69 for qemu-devel@nongnu.org; Fri, 24 Aug 2012 04:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4p4W-0008Hd-Hb for qemu-devel@nongnu.org; Fri, 24 Aug 2012 04:17:01 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:38295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4p4W-0008HV-Aq for qemu-devel@nongnu.org; Fri, 24 Aug 2012 04:16:52 -0400 Received: by eeke53 with SMTP id e53so603965eek.4 for ; Fri, 24 Aug 2012 01:16:51 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50373871.9020809@redhat.com> Date: Fri, 24 Aug 2012 10:16:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1345755722-25229-1-git-send-email-sw@weilnetz.de> <50373BE0.4020203@suse.de> In-Reply-To: <50373BE0.4020203@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: Stefan Weil , qemu-devel@nongnu.org Il 24/08/2012 10:31, Hannes Reinecke ha scritto: > >> Type casts from pointer to integer values must use uintptr_t >> instead of unsigned long. Otherwise the compiler complains on >> hosts with sizeof(pointer) != sizeof(long). >> >> The patch also replace magic number 32 by sizeof(info.serial_number) >> which has the same value but is better for code reviews. >> >> Signed-off-by: Stefan Weil > > Sigh. I never seem to get the hang of typecasting. > > Acked-by: Hannes Reinecke Nope, this needs to be fixed using the same scheme that you used for SAS addresses. Quick before Anthony notices and disables MEGASAS. :) Paolo