From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4nQl-0002NB-B3 for qemu-devel@nongnu.org; Fri, 24 Aug 2012 02:31:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4nQk-0002Rk-BY for qemu-devel@nongnu.org; Fri, 24 Aug 2012 02:31:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43816 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4nQk-0002RH-5B for qemu-devel@nongnu.org; Fri, 24 Aug 2012 02:31:42 -0400 Message-ID: <50373BE0.4020203@suse.de> Date: Fri, 24 Aug 2012 10:31:28 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1345755722-25229-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1345755722-25229-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On 08/23/2012 11:02 PM, Stefan Weil wrote: > Type casts from pointer to integer values must use uintptr_t > instead of unsigned long. Otherwise the compiler complains on > hosts with sizeof(pointer) !=3D sizeof(long). > > The patch also replace magic number 32 by sizeof(info.serial_number) > which has the same value but is better for code reviews. > > Signed-off-by: Stefan Weil Sigh. I never seem to get the hang of typecasting. Acked-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Markus Rex, HRB 16746 (AG N=FCrnberg)