From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4r45-0005te-TM for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:24:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4r44-0003fm-Vc for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:24:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4r44-0003ff-Nr for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:24:32 -0400 Message-ID: <5037565A.5000901@redhat.com> Date: Fri, 24 Aug 2012 12:24:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1345801763-24227-1-git-send-email-qemulist@gmail.com> <1345801763-24227-8-git-send-email-qemulist@gmail.com> In-Reply-To: <1345801763-24227-8-git-send-email-qemulist@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Liu Ping Fan , qemu-devel@nongnu.org, Anthony Liguori , Avi Kivity Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > We are not long to force to delete the obj at that place, just > let its refcnt handle this issue. This seems wrong. If anything, unplug requests should propagate down the tree and the top device should only acknowledge it hot-unplug after all its children. You are effectively surprise-removing everything below a bridge. Paolo