From: Julien Grall <julien.grall@citrix.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"christian.limpach@gmail.com" <christian.limpach@gmail.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server
Date: Fri, 24 Aug 2012 11:33:16 +0100 [thread overview]
Message-ID: <5037586C.5000902@citrix.com> (raw)
In-Reply-To: <CC5BEE01.3CBD1%keir.xen@gmail.com>
On 08/23/2012 02:26 PM, Keir Fraser wrote:
> On 23/08/2012 14:18, "Ian Campbell"<Ian.Campbell@citrix.com> wrote:
>
>
>>> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h
>>> index 4022a1d..87aacd3 100644
>>> --- a/xen/include/public/hvm/ioreq.h
>>> +++ b/xen/include/public/hvm/ioreq.h
>>> @@ -34,6 +34,7 @@
>>>
>>> #define IOREQ_TYPE_PIO 0 /* pio */
>>> #define IOREQ_TYPE_COPY 1 /* mmio ops */
>>> +#define IOREQ_TYPE_PCI_CONFIG 2 /* pci config space ops */
>>> #define IOREQ_TYPE_TIMEOFFSET 7
>>> #define IOREQ_TYPE_INVALIDATE 8 /* mapcache */
>>>
>> I wonder why we skip 2-6 now -- perhaps they used to be something else
>> and we are avoiding them to avoid strange errors? In which case adding
>> the new on as 9 might be a good idea.
>>
> They were almost certainly used for representing R-M-W ALU operations back
> in the days of the old IO emulator, very long ago. Still, there's no harm in
> leaving them unused.
>
Ok. So I will use number 9 for IOREQ_TYPE_PCI_CONFIG.
next prev parent reply other threads:[~2012-08-24 10:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 12:31 [Qemu-devel] [XEN][RFC PATCH V2 00/17] QEMU disaggregation in Xen environment Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server Julien Grall
2012-08-23 13:18 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2012-08-23 13:26 ` Keir Fraser
2012-08-24 10:33 ` Julien Grall [this message]
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 02/17] hvm: Add functions to handle ioreq servers Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 03/17] hvm-pci: Handle PCI config space in Xen Julien Grall
2012-08-23 7:20 ` [Qemu-devel] [Xen-devel] " Jan Beulich
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 04/17] hvm: Change initialization/destruction of an hvm Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 05/17] hvm: Modify hvm_op Julien Grall
2012-08-23 7:27 ` [Qemu-devel] [Xen-devel] " Jan Beulich
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 06/17] hvm-io: IO refactoring with ioreq server Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 07/17] hvm-io: send invalidate map cache to each registered servers Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 08/17] hvm-io: Handle server in buffered IO Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 09/17] xc: Add the hypercall for multiple servers Julien Grall
2012-08-23 13:21 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 10/17] xc: Add argument to allocate more special pages Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models Julien Grall
2012-08-23 13:27 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2012-08-23 19:13 ` Julien Grall
2012-08-23 19:52 ` Ian Campbell
2012-08-24 10:27 ` Julien Grall
2012-08-24 10:35 ` Ian Campbell
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation Julien Grall
2012-08-23 13:30 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2012-08-24 12:56 ` Julien Grall
2012-08-24 13:03 ` Ian Campbell
2012-08-24 13:23 ` Julien Grall
2012-08-22 12:31 ` [Qemu-devel] [XEN][RFC PATCH V2 13/17] xl: add device model id to qmp functions Julien Grall
2012-08-22 12:32 ` [Qemu-devel] [XEN][RFC PATCH V2 14/17] xl-parsing: Parse new device_models option Julien Grall
2012-08-23 13:35 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2012-08-24 13:12 ` Julien Grall
2012-08-22 12:32 ` [Qemu-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model Julien Grall
2012-08-23 13:56 ` [Qemu-devel] [Xen-devel] " Ian Campbell
2012-08-24 13:51 ` Julien Grall
2012-08-24 14:09 ` Ian Campbell
2012-08-24 14:37 ` Julien Grall
2012-08-24 14:45 ` Ian Campbell
2012-08-22 12:32 ` [Qemu-devel] [XEN][RFC PATCH V2 16/17] xl: Fix PCI library Julien Grall
2012-08-22 12:32 ` [Qemu-devel] [XEN][RFC PATCH V2 17/17] xl: implement save/restore for multiple device models Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5037586C.5000902@citrix.com \
--to=julien.grall@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=christian.limpach@gmail.com \
--cc=keir.xen@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).