From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T4sVB-0006jd-2W
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 07:56:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T4sVA-0005pW-69
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 07:56:36 -0400
Received: from mail-ee0-f45.google.com ([74.125.83.45]:62618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T4sV9-0005pP-W0
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 07:56:36 -0400
Received: by eeke53 with SMTP id e53so691737eek.4
	for <qemu-devel@nongnu.org>; Fri, 24 Aug 2012 04:56:34 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50376BEF.5060206@redhat.com>
Date: Fri, 24 Aug 2012 13:56:31 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120824094738.GH29273@rox.home.comstyle.com>
	<CAFEAcA_6C3eQEUy1q8eNxTUdbGcH=8ida56Ded9rP_h8yrimWQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_6C3eQEUy1q8eNxTUdbGcH=8ida56Ded9rP_h8yrimWQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Brad Smith <brad@comstyle.com>

Il 24/08/2012 11:55, Peter Maydell ha scritto:
>> > OpenBSD's uname works as expected with the -s flag so remove the special
>> > handling when determining the target OS. Use arch -s to retrieve the
>> > hardware architecture as uname -m will return the meta architecture
>> > instead of the hardware architecture (.e.g. macppc vs powerpc).
> I'm afraid I think this patch is moving in the wrong direction.
> Wherever possible we should be using compiler checks like check_define,
> not looking at the output of 'uname' and the like. The former will
> work when cross compiling, and the latter will give the wrong answers.
> In some places we have that kind of 'look at uname/etc' check but
> we should be trying to reduce and eliminate it where possible.

Right, we should support GNU triplets and a --host argument, and replace
uname checks with pattern matching on the triplet.

Paolo