From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T4v7K-0003E2-H6
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 10:44:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T4v7J-0002NR-5r
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 10:44:10 -0400
Received: from mail-ey0-f173.google.com ([209.85.215.173]:37553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1T4v7I-0002NG-Vm
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 10:44:09 -0400
Received: by eaac13 with SMTP id c13so611093eaa.4
	for <qemu-devel@nongnu.org>; Fri, 24 Aug 2012 07:44:08 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50379336.7040905@redhat.com>
Date: Fri, 24 Aug 2012 16:44:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1345801763-24227-1-git-send-email-qemulist@gmail.com>
	<1345801763-24227-7-git-send-email-qemulist@gmail.com>
In-Reply-To: <1345801763-24227-7-git-send-email-qemulist@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Liu Ping Fan <pingfank@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Avi Kivity <avi@redhat.com>

Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> 
> qmp and qdev need it.
> 
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> ---
>  include/qemu/object.h |    3 +++
>  qom/object.c          |    2 +-
>  2 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/include/qemu/object.h b/include/qemu/object.h
> index 7cc3ebb..0142da4 100644
> --- a/include/qemu/object.h
> +++ b/include/qemu/object.h
> @@ -914,6 +914,9 @@ Object *object_resolve_path_component(Object *parent, gchar *part);
>  void object_property_add_child(Object *obj, const char *name,
>                                 Object *child, struct Error **errp);
>  
> +void object_property_del_child(Object *obj, Object *child,
> +                                struct Error **errp);
> +
>  /**
>   * object_property_add_link:
>   * @obj: the object to add a property to
> diff --git a/qom/object.c b/qom/object.c
> index be460df..6c90cfa 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -345,7 +345,7 @@ static void object_property_del_all(Object *obj)
>      }
>  }
>  
> -static void object_property_del_child(Object *obj, Object *child, Error **errp)
> +void object_property_del_child(Object *obj, Object *child, Error **errp)
>  {
>      ObjectProperty *prop;
>  
> 

Not needed, see my reply to patch 9.

Paolo