From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4vFm-0000gF-CQ for qemu-devel@nongnu.org; Fri, 24 Aug 2012 10:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4vFb-0005aK-RB for qemu-devel@nongnu.org; Fri, 24 Aug 2012 10:52:54 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:36609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4vFb-0005aE-L2 for qemu-devel@nongnu.org; Fri, 24 Aug 2012 10:52:43 -0400 Received: by eeke53 with SMTP id e53so768116eek.4 for ; Fri, 24 Aug 2012 07:52:42 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50379539.4090707@redhat.com> Date: Fri, 24 Aug 2012 16:52:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1345801763-24227-1-git-send-email-qemulist@gmail.com> <1345801763-24227-2-git-send-email-qemulist@gmail.com> In-Reply-To: <1345801763-24227-2-git-send-email-qemulist@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to ref, unref its target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Liu Ping Fan , qemu-devel@nongnu.org, Anthony Liguori , Avi Kivity Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > Currently, link property's target is only managed by > object_set_link_property(). This will raise such issue that when > the property is finalized, its target has no opportunity to release. > > Fix this issue by introduce object_finalize_link_property() > In correspond, ref target when adding link prpoerty. > > Signed-off-by: Liu Ping Fan > --- This patch is fine, but it is at the wrong place in the series. It will cause an assertion failure due to the unbroken circular reference. Paolo