From: "Andreas Färber" <afaerber@suse.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions
Date: Fri, 24 Aug 2012 17:52:29 +0200 [thread overview]
Message-ID: <5037A33D.3070907@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1208241934340.3037@linmac>
Am 24.08.2012 17:35, schrieb malc:
> On Fri, 24 Aug 2012, malc wrote:
>
>> On Fri, 24 Aug 2012, Aurelien Jarno wrote:
>>
>>> On Sun, Mar 11, 2012 at 10:24:03PM +0000, Blue Swirl wrote:
>
> [..snip..]
>
>>> - On 32 bit hosts, which usually need register alignments for 64-bit
>>> values (at least on arm and mips), given AREG0 is a 32-bit value this
>> ditto ppc32, erm.. with sysv abi that is
...which have been fixed in the v1.1 release cycle. You can take a look
at tcg/ppc/ for how we've fixed that with alignment macros and variable.
Not opposed to changing the argument order, but given that we're inches
away from v1.2 (in Hard Freeze), it might be better to first get AREG0
as first argument working for your favorite hosts as a bugfix and then
do any larger optimization for v1.3.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-24 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 22:24 [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions Blue Swirl
2012-08-24 15:05 ` Aurelien Jarno
2012-08-24 15:33 ` malc
2012-08-24 15:35 ` malc
2012-08-24 15:52 ` Andreas Färber [this message]
2012-08-24 16:26 ` malc
2012-08-24 18:20 ` Andreas Färber
2012-08-24 18:05 ` Aurelien Jarno
2012-08-24 18:43 ` Andreas Färber
2012-08-24 18:53 ` Aurelien Jarno
2012-08-25 9:18 ` Blue Swirl
2012-08-25 12:56 ` Aurelien Jarno
2012-08-24 23:01 ` Peter Maydell
2012-08-25 9:52 ` Blue Swirl
2012-09-20 11:46 ` Alexander Graf
2012-08-25 12:53 ` Aurelien Jarno
2012-08-25 23:28 ` Peter Maydell
2012-08-26 1:03 ` Peter Maydell
2012-08-25 9:05 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5037A33D.3070907@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).