From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T4wBd-0005RD-C5
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 11:52:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T4wBW-0000Ty-RJ
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 11:52:41 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43454 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T4wBW-0000Na-Az
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 11:52:34 -0400
Message-ID: <5037A33D.3070907@suse.de>
Date: Fri, 24 Aug 2012 17:52:29 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <CAAu8pHsGmVBNFzrTxOmOxVgHT5kL4eR-LQJz85V6-ri=5xnQtg@mail.gmail.com>
	<20120824150557.GG1687@hall.aurel32.net>
	<alpine.LNX.2.00.1208241932510.2943@linmac>
	<alpine.LNX.2.00.1208241934340.3037@linmac>
In-Reply-To: <alpine.LNX.2.00.1208241934340.3037@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass
 CPUState to memory access functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Am 24.08.2012 17:35, schrieb malc:
> On Fri, 24 Aug 2012, malc wrote:
>=20
>> On Fri, 24 Aug 2012, Aurelien Jarno wrote:
>>
>>> On Sun, Mar 11, 2012 at 10:24:03PM +0000, Blue Swirl wrote:
>=20
> [..snip..]
>=20
>>> - On 32 bit hosts, which usually need register alignments for 64-bit
>>>   values (at least on arm and mips), given AREG0 is a 32-bit value th=
is
>>             ditto ppc32, erm.. with sysv abi that is

...which have been fixed in the v1.1 release cycle. You can take a look
at tcg/ppc/ for how we've fixed that with alignment macros and variable.

Not opposed to changing the argument order, but given that we're inches
away from v1.2 (in Hard Freeze), it might be better to first get AREG0
as first argument working for your favorite hosts as a bugfix and then
do any larger optimization for v1.3.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg