* [Qemu-devel] [PATCH for 1.2] memory: Fix copy&paste mistake in memory_region_iorange_write
@ 2012-08-26 8:12 Jan Kiszka
0 siblings, 0 replies; only message in thread
From: Jan Kiszka @ 2012-08-26 8:12 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori; +Cc: Avi Kivity
From: Jan Kiszka <jan.kiszka@siemens.com>
The last argument of find_portio is "write", so this must be true here.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
We were likely lucky so far and didn't hit this - it would have caused
an assertion. However, there are also rarely used devices...
memory.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/memory.c b/memory.c
index 643871b..d528d1f 100644
--- a/memory.c
+++ b/memory.c
@@ -426,7 +426,7 @@ static void memory_region_iorange_write(IORange *iorange,
if (mrp) {
mrp->write(mr->opaque, offset, data);
} else if (width == 2) {
- mrp = find_portio(mr, offset - mrio->offset, 1, false);
+ mrp = find_portio(mr, offset - mrio->offset, 1, true);
assert(mrp);
mrp->write(mr->opaque, offset, data & 0xff);
mrp->write(mr->opaque, offset + 1, data >> 8);
--
1.7.3.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-26 8:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-26 8:12 [Qemu-devel] [PATCH for 1.2] memory: Fix copy&paste mistake in memory_region_iorange_write Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).