From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35318)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T5eky-0002sN-EE
	for qemu-devel@nongnu.org; Sun, 26 Aug 2012 11:28:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T5ekw-0003wT-18
	for qemu-devel@nongnu.org; Sun, 26 Aug 2012 11:28:08 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43619 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1T5ekv-0003wL-R0
	for qemu-devel@nongnu.org; Sun, 26 Aug 2012 11:28:05 -0400
Message-ID: <503A407F.8080900@suse.de>
Date: Sun, 26 Aug 2012 17:27:59 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1345990448-15587-1-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1345990448-15587-1-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec
	instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Am 26.08.2012 16:14, schrieb Aurelien Jarno:
> Altivec instructions are not working anymore in PowerPC emulation,
> following commit d15f74fb, which inverted two registers in the call
> to helper. Fix that.
>=20
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Andreas F=C3=A4rber <afaerber@suse.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>

This looks right, but do you have a particular test case I can check?

Andreas

> ---
>  target-ppc/translate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 91eb7a0..ac915cc 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6530,7 +6530,7 @@ static void glue(gen_, name)(DisasContext *ctx)  =
                       \
>      ra =3D gen_avr_ptr(rA(ctx->opcode));                              =
    \
>      rb =3D gen_avr_ptr(rB(ctx->opcode));                              =
    \
>      rd =3D gen_avr_ptr(rD(ctx->opcode));                              =
    \
> -    gen_helper_##name(rd, cpu_env, ra, rb);                           =
  \
> +    gen_helper_##name(cpu_env, rd, ra, rb);                           =
  \
>      tcg_temp_free_ptr(ra);                                            =
  \
>      tcg_temp_free_ptr(rb);                                            =
  \
>      tcg_temp_free_ptr(rd);                                            =
  \
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg