From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com,
xiawenc@linux.vnet.ibm.com, "Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info
Date: Mon, 27 Aug 2012 11:52:59 -0600 [thread overview]
Message-ID: <503BB3FB.5060901@redhat.com> (raw)
In-Reply-To: <1346051752-13551-1-git-send-email-benoit@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On 08/27/2012 01:15 AM, Benoît Canet wrote:
> This patchset add a JSON output mode to the qemu-img info command.
> It's a rewrite from scratch of the original patchset by Wenchao Xia
> following Anthony Liguori advices on JSON formating.
>
> the --output=(json|human) option is now mandatory on the command line.
This statement is not true, but doesn't affect the series itself.
> in v6:
>
> Blue Swirl: -Add missing const in getopt structure declaration.
>
> Eric Blake: -Remove spurious undef.
> -Use an enum instead of two boolean.
You have now addressed my complaints about the interface, but I would
feel comfortable if someone more familiar with qemu-img itself gives
final review and/or ack.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-08-27 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 7:15 [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info Benoît Canet
2012-08-27 7:15 ` [Qemu-devel] [PATCH V6 1/2] qapi: Add SnapshotInfo and ImageInfo Benoît Canet
2012-08-27 7:15 ` [Qemu-devel] [PATCH V6 2/2] qemu-img: Add json output option to the info command Benoît Canet
2012-09-04 12:54 ` Kevin Wolf
2012-09-04 19:01 ` Benoît Canet
2012-08-27 17:52 ` Eric Blake [this message]
2012-08-30 12:46 ` [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info Benoît Canet
2012-09-03 13:05 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503BB3FB.5060901@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).