From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63Ut-0005WG-Mz for qemu-devel@nongnu.org; Mon, 27 Aug 2012 13:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T63Us-0003PQ-4z for qemu-devel@nongnu.org; Mon, 27 Aug 2012 13:53:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63Ur-0003P0-Tf for qemu-devel@nongnu.org; Mon, 27 Aug 2012 13:53:10 -0400 Message-ID: <503BB3FB.5060901@redhat.com> Date: Mon, 27 Aug 2012 11:52:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1346051752-13551-1-git-send-email-benoit@irqsave.net> In-Reply-To: <1346051752-13551-1-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF9E15E04D429F6F2BA8AD295" Subject: Re: [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF9E15E04D429F6F2BA8AD295 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2012 01:15 AM, Beno=C3=AEt Canet wrote: > This patchset add a JSON output mode to the qemu-img info command. > It's a rewrite from scratch of the original patchset by Wenchao Xia > following Anthony Liguori advices on JSON formating. >=20 > the --output=3D(json|human) option is now mandatory on the command line= =2E This statement is not true, but doesn't affect the series itself. > in v6: >=20 > Blue Swirl: -Add missing const in getopt structure declaration. >=20 > Eric Blake: -Remove spurious undef. > -Use an enum instead of two boolean. You have now addressed my complaints about the interface, but I would feel comfortable if someone more familiar with qemu-img itself gives final review and/or ack. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF9E15E04D429F6F2BA8AD295 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQO7P7AAoJEKeha0olJ0Nqur0IAKQ24JFtR1IaO5gHomiWRgEO q2xFgrUgQffDSUeTL2F77RbsRduDBTAaCw0rNUNtzbh1+nMqY+OlEpwHH5okFgW2 oigrMYGo/xRoCfV4wEsn7DzVY379NAaTV8IZYCy8uplOSHOneHLD9Nr8PfZaMs9B HfMprYZXBUioZLuaZXIXoUsouNgb20Cs7deML9+8eYeeiFLNmijm9OXGWgueE8O1 Wv0+I4YdurvFW1xPdWLWp0A/eZy4ns+jU5IZhAtwpkyKAJGkQLR8KDAoHxGTp2t3 0DCg/KE6rGXgZ4hb74TOra24sSaSTN6H41xeo4kmUaI7CXFyeTYvfCRbceo6sp4= =9WQu -----END PGP SIGNATURE----- --------------enigF9E15E04D429F6F2BA8AD295--