From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63bG-0006i1-N4 for qemu-devel@nongnu.org; Mon, 27 Aug 2012 13:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T63bE-00055P-90 for qemu-devel@nongnu.org; Mon, 27 Aug 2012 13:59:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63bE-000551-05 for qemu-devel@nongnu.org; Mon, 27 Aug 2012 13:59:44 -0400 Message-ID: <503BB586.5000503@redhat.com> Date: Mon, 27 Aug 2012 11:59:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1346052629-15686-1-git-send-email-benoit@irqsave.net> <1346052629-15686-4-git-send-email-benoit@irqsave.net> In-Reply-To: <1346052629-15686-4-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4E6B91A54F923D5F050D7E49" Subject: Re: [Qemu-devel] [RFC V5 03/11] quorum: Add quorum_open() and quorum_close(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4E6B91A54F923D5F050D7E49 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2012 01:30 AM, Beno=C3=AEt Canet wrote: > Valid quorum resources look like > quorum:threshold/total:path/to/image_1, ... ,path/to/image_total >=20 > ',' is used as a separator to allow to use networked path Isn't this a step backwards? After all, on the command line, we would have something like: -drive file=3Dquorum:...,readonly=3Don but if the 'quorum:...' portion contains commas, then the qemu option parsing requires you to write those commas as doubled. Which means to escape those commas for _both_ quorum: processing _and_ qemu command line parsing, I'd have to write: -drive "file=3Dquorum:2/2:path/to/image\\,,1,,path/to/image\\\\2,readonly= =3Don" to use the two files: path/to/image,1 path/to/image\2 with appropriate shell, qemu, and quorum escaping. Using : rather than , as the separator between quorum: elements was a bit simpler, since I don't have to type double commas for every single comma to be taken by the quorum parsing, escaped or not. > '\' is the escaping character for filename containing ',' > '\' escape itself s/escape/escapes/ >=20 > On the command line for quorum files "img,test.raw", "img2.raw" > and "img3.raw" invocation look like: >=20 > -drive file=3Dquorum:2/3:img\\,,test.raw,,img2.raw,,img3.raw > (note the double ,, and \\) Yes, that's what I'm worried about. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4E6B91A54F923D5F050D7E49 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQO7WGAAoJEKeha0olJ0NqXNMIAJVrwvKxnq4uKTkm7nzQug8c D6XPn9z+HZRCXgHVuGW7wAOzeCBbJukUMZRcomSLaw9YZNqC/bQjI0voowPmfQHH J41hVDLE0OlkVUt+laBp+UrNym3bQehiDeWdMuwLkTiEM3ycNwAf1quMoWdVm0kk lwt12P9fbdjT2uYdmyB3CQuCbKgoCW1jh8DYUwrGhDlm2XgFiwzNCm8xR7ZgsuNT n81rlwxLxDahF8+4NKkloP8z6EwBByVWsw3rtnulVueepYZqzwzsC0qvQUNXH+K1 AulWQoXBNP6aLUZZnH0+nzMQ1JPSfjIoNRlzdKG1vsQ6mc1AlpizG20JSYkKb8o= =WkLq -----END PGP SIGNATURE----- --------------enig4E6B91A54F923D5F050D7E49--