From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63fQ-0007x9-KP for qemu-devel@nongnu.org; Mon, 27 Aug 2012 14:04:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T63fM-0006eB-Li for qemu-devel@nongnu.org; Mon, 27 Aug 2012 14:04:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T63fM-0006e5-Bi for qemu-devel@nongnu.org; Mon, 27 Aug 2012 14:04:00 -0400 Message-ID: <503BB684.5000007@redhat.com> Date: Mon, 27 Aug 2012 12:03:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1346052629-15686-1-git-send-email-benoit@irqsave.net> <1346052629-15686-10-git-send-email-benoit@irqsave.net> In-Reply-To: <1346052629-15686-10-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig42EF74AB9EFE118FD949709F" Subject: Re: [Qemu-devel] [RFC V5 09/11] quorum: Add quorum_getlength(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig42EF74AB9EFE118FD949709F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2012 01:30 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Say I'm using a 2/3 quorum. What happens if: image A and B agree on initial content, but not length image B and C agree on length, but not content Does disagreeing with quorum consensus invalidate that member of the quorum from influencing further decisions? If there is a length discrepancy, should we declare the quorum failed rather than relying on a mere majority vote? Or, if there is a length discrepancy, does reading the contents beyond the end of the shorter files consider the contents to be okay if the longer files have only NUL bytes in the extra length? I'm worried that you haven't fully thought through all the scenarios here. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig42EF74AB9EFE118FD949709F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQO7aFAAoJEKeha0olJ0NqA2sH/RcaUCDpv2U+E004ZXYL4zzf XrXu82kyxYRoYToFqHqTU29E6yt2IbGWmGGeAL1/oDxrgcae6IQoUmj8TA8d1Bmf 0/sZuEqfqvDYiP/KbrDGC22n6hUTM3T1Vsf/AZEutCBVOHlCrA7OrrrfMRYeG0VG OWiLO2zjqUFfp4aG0IWJaNcdOJ6LGzwc1ihBDx9ZvO0hf6/w+pxh+FLe83LwYWXw JyJUrHh5lH1mkCO8Fb2F4ijY3StT0cy+nv/FPf3hRPAHSVEXnM9uG2aezsLlSzDW zl+wPb0GDiyPy4vtRMXJx5f5wIvKPhKD0v2u3OkW+6NGeAaenZ7mrl95HhGQYZk= =OV0W -----END PGP SIGNATURE----- --------------enig42EF74AB9EFE118FD949709F--