From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T6F9D-0007QV-AB
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 02:19:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T6F9C-0005Gs-GO
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 02:19:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24756)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T6F9C-0005Go-7y
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 02:19:34 -0400
Message-ID: <503C62F1.8060107@redhat.com>
Date: Tue, 28 Aug 2012 08:19:29 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1346088041-17062-1-git-send-email-sandmann@cs.au.dk>
	<1346088041-17062-4-git-send-email-sandmann@cs.au.dk>
In-Reply-To: <1346088041-17062-4-git-send-email-sandmann@cs.au.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qxl: Add set_client_capabilities()
	interface to QXLInterface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?U8O4cmVuIFNhbmRtYW5uIFBlZGVyc2Vu?= <sandmann@cs.au.dk>
Cc: qemu-devel@nongnu.org, spice-devel@freedesktop.org, =?UTF-8?B?U8O4cmVu?= =?UTF-8?B?IFNhbmRtYW5uIFBlZGVyc2Vu?= <ssp@redhat.com>

On 08/27/12 19:20, S=C3=B8ren Sandmann Pedersen wrote:
> From: S=C3=B8ren Sandmann Pedersen <ssp@redhat.com>
>=20
> This new interface lets spice server inform the guest whether
>=20
> (a) a client is connected
> (b) what capabilities the client has
>=20
> There is a fixed number (464) of bits reserved for capabilities, and
> when the capabilities bits change, the QXL_INTERRUPT_CLIENT interrupt
> is generated.

Needs some #ifdefs to make sure qemu continues to build with old
spice-server versions.

>      case 3: /* qxl-3 */
> +	pci_device_rev =3D QXL_REVISION_STABLE_V10;
> +	io_size =3D msb_mask(QXL_IO_RANGE_SIZE * 2 - 1);
> +	break;
> +    case 5:

I think there is no need to jump to 5, we can use revision 4 for both
client capabilities and monitors config.

cheers,
  Gerd