From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6Nuj-0000xU-Au for qemu-devel@nongnu.org; Tue, 28 Aug 2012 11:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6Nui-0006ap-4n for qemu-devel@nongnu.org; Tue, 28 Aug 2012 11:41:13 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:30780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6Nuh-0006XJ-Vx for qemu-devel@nongnu.org; Tue, 28 Aug 2012 11:41:12 -0400 Message-ID: <503CE6E1.2040302@citrix.com> Date: Tue, 28 Aug 2012 16:42:25 +0100 From: Julien Grall MIME-Version: 1.0 References: <76c2fcb7375a3b75f2b46fb24f4902d77df2600a.1345549695.git.julien.grall@citrix.com> <5037A77C.3070607@suse.de> In-Reply-To: <5037A77C.3070607@suse.de> Content-Type: text/plain; charset="ISO-8859-15"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V5 1/8] isa: add isa_address_space_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Jan Kiszka , Stefano Stabellini , Gerd Hoffmann , "qemu-devel@nongnu.org" , "avi@redhat.com" On 08/24/2012 05:10 PM, Andreas Färber wrote: > Am 22.08.2012 14:27, schrieb Julien Grall: > >> This function permits to retrieve ISA IO address space. >> It will be usefull when we need to pass IO address space as argument. >> >> Signed-off-by: Julien Grall >> --- >> hw/isa-bus.c | 5 +++++ >> hw/isa.h | 1 + >> 2 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/hw/isa-bus.c b/hw/isa-bus.c >> index f9b2373..662c86b 100644 >> --- a/hw/isa-bus.c >> +++ b/hw/isa-bus.c >> @@ -244,4 +244,9 @@ MemoryRegion *isa_address_space(ISADevice *dev) >> return get_system_memory(); >> } >> >> +MemoryRegion *isa_address_space_io(ISADevice *dev) >> +{ >> + return get_system_io(); >> +} >> > Unlike the address_space above, there's an address_space_io field in > ISABus, so I guess the implementation of this function should rather > obtain the device's BusState via isa_bus_from_device(dev) and return its > field rather than hardcoding get_system_io() here. > I use this function in hw/dma.c. For the moment, the code doesn't use ISA device, so I pass NULL to isa_address_space_io (See patch 6). Instead of using isa_bus_from_device, can I just return "isabus->address_space_io" as in isa_register_portio_list ? -- Julien Grall