From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6dvX-0005b2-Bd for qemu-devel@nongnu.org; Wed, 29 Aug 2012 04:47:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6dvV-0007he-Pj for qemu-devel@nongnu.org; Wed, 29 Aug 2012 04:47:07 -0400 Message-ID: <503DD705.8020406@siemens.com> Date: Wed, 29 Aug 2012 10:47:01 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <503B64D9.4000708@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "kvm@vger.kernel.org" , "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , "qemu-devel@nongnu.org" , Alex Williamson , qemu-ppc , Avi Kivity , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 2012-08-28 23:26, Peter Maydell wrote: > On 27 August 2012 13:15, Jan Kiszka wrote: >> On 2012-08-27 14:07, Andreas F=C3=A4rber wrote: >>> Am I correct to understand we compile this only for i386 / x86_64? >> >> This is correct. >=20 > Did we ever make a decision about whether architecture specific > KVM devices should all live in hw/kvm/ or in some directory > with the arch name in it? I guess they're all in hw/kvm/ at > the moment so they should stay there unless there's a pressing > reason to move them around... Yep, that would be the plan. As long as there are x86 platform devices under hw/kvm, I see no point putting this one elsewhere. It's trivially moved when time has come. >=20 > Since this is arch-specific we should probably give the > resulting device a more specific name than "pci-assign", > which implies that it is (a) ok for any PCI system and > (b) not something that will be obsolete in the foreseen > future. The name has to be like this for libvirt compatibility. I can provide it as alias, though, calling the device "kvm-pci-assign" by default. Better? Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux