From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6iVn-00063D-6Y for qemu-devel@nongnu.org; Wed, 29 Aug 2012 09:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6iVj-0006D6-Tg for qemu-devel@nongnu.org; Wed, 29 Aug 2012 09:40:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6iVj-0006Cf-LN for qemu-devel@nongnu.org; Wed, 29 Aug 2012 09:40:47 -0400 Message-ID: <503E1BDB.8010406@redhat.com> Date: Wed, 29 Aug 2012 09:40:43 -0400 From: Jeff Cody MIME-Version: 1.0 References: <1344930090.9132.29.camel@storm> In-Reply-To: <1344930090.9132.29.camel@storm> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 0/4] Live block commit Reply-To: jcody@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tiziano.mueller@stepping-stone.ch Cc: qemu-devel@nongnu.org On 08/14/2012 03:41 AM, Tiziano M=C3=BCller wrote: > Hi Jeff >=20 > This is an awesome feature and absolutely necessary to get a working > live-snapshot/backup solution. >=20 > What is the status on this? Will it make it into 1.2.0? >=20 > Thanks in advance, > best regards, > Tiziano Hi Tiziano, Sorry, I didn't catch your email before (feel free to cc me on any direct questions). This did not make it into 1.2, but it should make it into 1.3. I am prepping a new patch series now to send out (which is how I ran across your email, as I was double checking that I did not miss any review comments - I must have missed it when you first sent it). Thanks, Jeff >=20 > Am Dienstag, den 31.07.2012, 01:16 -0400 schrieb Jeff Cody: >> These are proposed changes, to add live block commit functionality. >> >> I originally had intended for this RFC series to include the more >> complicated case of a live commit of the active layer, but removed >> it for this commit in the hopes of making it into the soft feature >> freeze for 1.2, so this series is the simpler case. >> >> This series adds the basic case, of a live commit between two >> images below the active layer, e.g.: >> >> [base] <--- [snp-1] <--- [snp-2] <--- [snp-3] <--- [active] >> >> can be collapsed down via commit, into: >> >> [base] <--- [active] >> >> or, >> >> [base] <--- [snp-1] <--- [active], >> >> [base] <--- [snp-3] <--- [active], >> >> etc.. >> >> >> qemu-io tests for the block commit will be adding onto the v1 patch >> set. >> >> These patches are on top of Supriya's reopen() series, and Paolo's >> block mirror series (the RFC series). I have not rebased yet to the >> newer patches put out by Supriya and Paolo - this was tested w/o the >> reopen, by manually making sure the images stayed in a r/w state. >> >> >> Jeff Cody (4): >> block: add support functions for live commit, to find and delete >> images. >> block: add live block commit functionality >> qerror: new errors for live block commit, QERR_TOP_NOT_FOUND >> QAPI: add command for live block commit, 'block-commit' >> >> block.c | 136 ++++++++++++++++++++++++++++++++++- >> block.h | 4 ++ >> block/Makefile.objs | 2 +- >> block/commit.c | 200 ++++++++++++++++++++++++++++++++++++++++++= +++++++++ >> block_int.h | 19 +++++ >> blockdev.c | 78 ++++++++++++++++++++ >> qapi-schema.json | 33 +++++++++ >> qerror.c | 4 ++ >> qerror.h | 3 + >> qmp-commands.hx | 6 ++ >> trace-events | 2 + >> 11 files changed, 485 insertions(+), 2 deletions(-) >> create mode 100644 block/commit.c >> >=20