From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6ixE-0004bq-Tx for qemu-devel@nongnu.org; Wed, 29 Aug 2012 10:09:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6ix8-0006xy-SB for qemu-devel@nongnu.org; Wed, 29 Aug 2012 10:09:12 -0400 Message-ID: <503E227B.40904@suse.de> Date: Wed, 29 Aug 2012 16:08:59 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> In-Reply-To: <87k3wjyy0e.fsf@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , Jan Kiszka , Avi Kivity , qemu-ppc Am 28.08.2012 14:57, schrieb Anthony Liguori: > Andreas F=C3=A4rber writes: >=20 >> Hi, >> >> Am 27.08.2012 08:28, schrieb Jan Kiszka: >>> From: Jan Kiszka >>> >>> This adds PCI device assignment for i386 targets using the classic KV= M >>> interfaces. This version is 100% identical to what is being maintaine= d >>> in qemu-kvm for several years and is supported by libvirt as well. It= is >>> expected to remain relevant for another couple of years until kernels >>> without full-features and performance-wise equivalent VFIO support ar= e >>> obsolete. >>> >>> A refactoring to-do that should be done in-tree is to model MSI and >>> MSI-X support via the generic PCI layer, similar to what VFIO is alre= ady >>> doing for MSI-X. This should improve the correctness and clean up the >>> code from duplicate logic. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> hw/kvm/Makefile.objs | 2 +- >>> hw/kvm/pci-assign.c | 1929 ++++++++++++++++++++++++++++++++++++++++= ++++++++++ >>> 2 files changed, 1930 insertions(+), 1 deletions(-) >>> create mode 100644 hw/kvm/pci-assign.c >> [...] >>> diff --git a/hw/kvm/pci-assign.c b/hw/kvm/pci-assign.c >>> new file mode 100644 >>> index 0000000..9cce02c >>> --- /dev/null >>> +++ b/hw/kvm/pci-assign.c >>> @@ -0,0 +1,1929 @@ >>> +/* >>> + * Copyright (c) 2007, Neocleus Corporation. >>> + * >>> + * This program is free software; you can redistribute it and/or mod= ify it >>> + * under the terms and conditions of the GNU General Public License, >>> + * version 2, as published by the Free Software Foundation. >> >> The downside of accepting this into qemu.git is that it gets us a huge >> blob of GPLv2-only code without history of contributors for GPLv2+ >> relicensing... >=20 > That is 100% okay. Why? The way this is being submitted I don't see why we should treat Jan's patch any different from a patch by IBM or Samsung where we've asked folks to fix the license to comply with what I thought was our new policy (it does not even contain a from-x-on-GPLv2+ notice). If we want to get rid of qemu-kvm by pulling this in nontheless (for which I do have sympathies from a packaging perspective) why not instead do a git-merge from qemu-kvm so that we have the full file history at hands inside qemu.git? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg