From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mst@redhat.com,
jan.kiszka@siemens.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, blauwirbel@gmail.com,
alex.williamson@redhat.com, kraxel@redhat.com,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers
Date: Thu, 30 Aug 2012 09:41:55 +0200 [thread overview]
Message-ID: <503F1943.8060007@redhat.com> (raw)
In-Reply-To: <20120830084945.3d8fd28d@thinkpad.mammed.net>
Il 30/08/2012 08:49, Igor Mammedov ha scritto:
>>> > > +static void qemu_system_powerdown(void)
> this is a bad naming that conflicts with global var qemu_system_powerdown, so
> bisectability of series is still broken.
> perhaps qemu_do_system_powerdown() would be better for function name,
> although it doesn't match common name pattern used for this kind of functions.
>
Just inline the function in this patch, and uninline it later.
Paolo
next prev parent reply other threads:[~2012-08-30 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 17:02 [Qemu-devel] [PATCH 0/5 v2] convert system_powerdown command to notifiers Igor Mammedov
2012-08-29 17:02 ` [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers Igor Mammedov
2012-08-29 17:06 ` Andreas Färber
2012-08-29 21:55 ` Igor Mammedov
2012-08-30 6:49 ` Igor Mammedov
2012-08-30 7:41 ` Paolo Bonzini [this message]
2012-08-30 8:17 ` Igor Mammedov
2012-08-29 17:02 ` [Qemu-devel] [PATCH 2/5] acpi: use notifier for signaling guest system_powerdown command Igor Mammedov
2012-08-29 17:02 ` [Qemu-devel] [PATCH 3/5] target-arm: " Igor Mammedov
2012-08-29 17:02 ` [Qemu-devel] [PATCH 4/5] target-sparc: " Igor Mammedov
2012-08-29 17:02 ` [Qemu-devel] [PATCH 5/5] cleanup unused qemu_system_powerdown Igor Mammedov
-- strict thread matches above, loose matches on Subject: below --
2012-09-05 21:06 [Qemu-devel] [PATCH 0/5 v3] convert system_powerdown command to notifiers Igor Mammedov
2012-09-05 21:06 ` [Qemu-devel] [PATCH 1/5] Introduce powerdown_notifiers Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503F1943.8060007@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).