From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DoV-0005Xg-3U for qemu-devel@nongnu.org; Thu, 30 Aug 2012 19:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7DoT-0005N7-TN for qemu-devel@nongnu.org; Thu, 30 Aug 2012 19:06:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DoT-0005Ke-Kw for qemu-devel@nongnu.org; Thu, 30 Aug 2012 19:06:13 -0400 Message-ID: <503FF1E1.6030108@redhat.com> Date: Thu, 30 Aug 2012 16:06:09 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE92955C9A3AB5FD0B4CB8DE8" Subject: Re: [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE92955C9A3AB5FD0B4CB8DE8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/30/2012 11:47 AM, Jeff Cody wrote: > The command for live block commit is added, which has the following > arguments: >=20 > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original image) > top: the top image of the commit - all data from inside top down > to base will be committed into base. optional (if not specified= , > it is the active image) - see note below > speed: maximum speed, in bytes/sec >=20 > note: eventually this will support merging down the active layer, > but that code is not yet complete. If the active layer is passed= > in currently as top, or top is left to the default, then the erro= r > QERR_TOP_NOT_FOUND will be returned. >=20 > The is done as a block job, so upon completion a BLOCK_JOB_COMPLETED wi= ll > be emitted. Likewise, the job can be canceled, and it is possible to track progress of the job or change the speed on the fly, using existing block job commands. Will the BLOCK_JOB_COMPLETED event have a new category listing that it was a commit job instead of a stream job that completed? That is, I think this patch is incomplete, and that you also need to modify QMP/qmp-events.txt to modify the 'type' field of BLOCK_JOB_{CANCELLED,COMPLETED} to distinguish this new sub-type of event= =2E > =20 > ## > +# @block-commit > +# > +# Live commit of data from child image nodes into parent nodes - i.e.,= > +# writes data between 'top' and 'base' into 'base'. > +# > +# @device: the name of the device > +# > +# @base: #optional The parent image of the device to write data into= =2E > +# If not specified, this is the original parent ima= ge. > +# > +# @top: #optional The child image, above which data will not be com= mitted > +# down. If not specified, this is the active layer= =2E > +# > +# @speed: #optional the maximum speed, in bytes per second > +# > +# Returns: Nothing on success > +# If commit or stream is already active on this device, Devic= eInUse > +# If @device does not exist, DeviceNotFound > +# If image commit is not supported by this device, NotSupport= ed > +# If @base does not exist, BaseNotFound > +# If @top does not exist, TopNotFound > +# If @speed is invalid, InvalidParameter > +# > +# Since: 1.2 1.3 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE92955C9A3AB5FD0B4CB8DE8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQP/HhAAoJEKeha0olJ0NqE5kH/i/5MqDccWJW+nYFM5yz2PVH vGN9wn2lBtpcBLsdlvycgaiTsFuGE97PQMIg/J7U9mA84AYsoTGMy7X4ViQD6irE 4gD0+LlHWClNIxsLQL+IEr0HG1W0Acc66AxBy1una6OtypkEsnjn7iTlBkqRVSNh oKktdtHxxDu/4V3hoXptMpxqKj4eif/0AH0k2FZN549WTC+MAihkNT3o79CQrFOL x5yZQjJNHn/0qrZkgS3heCHy8TwzdWTfTDNfGWOZtH+zUpKYELOJgqEAlGNRcggW /HJksDiOtkSKYDlokFSPqHc9zd7RyoP4vnrsjfwMOmi2nDH6Wm/lqzahv2FcZJE= =yCC3 -----END PGP SIGNATURE----- --------------enigE92955C9A3AB5FD0B4CB8DE8--