From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>,
Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/7] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test
Date: Tue, 21 Jan 2025 13:52:14 +0100 [thread overview]
Message-ID: <503fe36f-c0ce-42d7-a08d-21c46b495ab0@redhat.com> (raw)
In-Reply-To: <20250120210212.3890255-4-alex.bennee@linaro.org>
On 20/01/2025 22.02, Alex Bennée wrote:
> Until there are timers enabled the semantics of clock_step_next() will
> fail. Since d524441a36 (system/qtest: properly feedback results of
> clock_[step|set]) we will signal a FAIL if time doesn't advance.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qtest/npcm7xx_timer-test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c
> index 58f58c2f71..43711049ca 100644
> --- a/tests/qtest/npcm7xx_timer-test.c
> +++ b/tests/qtest/npcm7xx_timer-test.c
> @@ -465,7 +465,6 @@ static void test_periodic_interrupt(gconstpointer test_data)
> int i;
>
> tim_reset(td);
> - clock_step_next();
>
> tim_write_ticr(td, count);
> tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-01-21 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 21:02 [PATCH 0/7] testing/next (qtest timer stuff) Alex Bennée
2025-01-20 21:02 ` [PATCH 1/7] tests/docker: replicate the check-rust-tools-nightly CI job Alex Bennée
2025-01-20 21:02 ` [PATCH 2/7] tests/qtest: don't attempt to clock_step while waiting for virtio ISR Alex Bennée
2025-01-21 5:13 ` Thomas Huth
2025-01-20 21:02 ` [PATCH 3/7] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test Alex Bennée
2025-01-21 12:52 ` Thomas Huth [this message]
2025-01-20 21:02 ` [PATCH 4/7] tests/qtest: simplify qtest_process_inbuf Alex Bennée
2025-01-20 21:02 ` [PATCH 5/7] tests/qtest: rename qtest_send_prefix and roll-up into qtest_send Alex Bennée
2025-01-20 22:05 ` Daniel Henrique Barboza
2025-01-20 21:02 ` [PATCH 6/7] tests/qtest: tighten up the checks on clock_step Alex Bennée
2025-01-21 13:04 ` Peter Maydell
2025-01-20 21:02 ` [PATCH 7/7] Revert "util/timer: avoid deadlock when shutting down" Alex Bennée
2025-01-21 12:51 ` [PATCH 0/7] testing/next (qtest timer stuff) Thomas Huth
2025-01-21 13:50 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503fe36f-c0ce-42d7-a08d-21c46b495ab0@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=farosas@suse.de \
--cc=kfting@nuvoton.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).