From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7Rpd-0000hp-Mu for qemu-devel@nongnu.org; Fri, 31 Aug 2012 10:04:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7RpX-0002KW-MI for qemu-devel@nongnu.org; Fri, 31 Aug 2012 10:04:21 -0400 Received: from hub021-nj-7.exch021.serverdata.net ([206.225.164.223]:60133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7RpX-0002Jz-IB for qemu-devel@nongnu.org; Fri, 31 Aug 2012 10:04:15 -0400 Message-ID: <5040C45D.8000106@CloudSwitch.Com> Date: Fri, 31 Aug 2012 10:04:13 -0400 From: Don Slutz MIME-Version: 1.0 References: <1346416208-28004-1-git-send-email-foliveira@cloudswitch.com> In-Reply-To: <1346416208-28004-1-git-send-email-foliveira@cloudswitch.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fred Oliveira Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 08/31/12 08:30, Fred Oliveira wrote: > The check using INT_MAX (2147483647) is wrong in this case. > > Signed-off-by: Fred Oliveira > --- > target-i386/cpu.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 423e009..cbc172e 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -846,7 +846,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque, > { > X86CPU *cpu = X86_CPU(obj); > const int64_t min = 0; > - const int64_t max = INT_MAX; > + const int64_t max = INT64_MAX; > int64_t value; > > visit_type_int(v, &value, name, errp); I think this a *trivial patch. Adding *qemu-trivial@nongnu.org. -Don Slutz **