* [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G
@ 2012-08-31 12:30 Fred Oliveira
2012-08-31 14:04 ` Don Slutz
0 siblings, 1 reply; 2+ messages in thread
From: Fred Oliveira @ 2012-08-31 12:30 UTC (permalink / raw)
To: qemu-devel; +Cc: Fred Oliveira
The check using INT_MAX (2147483647) is wrong in this case.
Signed-off-by: Fred Oliveira <foliveira@cloudswitch.com>
---
target-i386/cpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 423e009..cbc172e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -846,7 +846,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
{
X86CPU *cpu = X86_CPU(obj);
const int64_t min = 0;
- const int64_t max = INT_MAX;
+ const int64_t max = INT64_MAX;
int64_t value;
visit_type_int(v, &value, name, errp);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G
2012-08-31 12:30 [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G Fred Oliveira
@ 2012-08-31 14:04 ` Don Slutz
0 siblings, 0 replies; 2+ messages in thread
From: Don Slutz @ 2012-08-31 14:04 UTC (permalink / raw)
To: Fred Oliveira; +Cc: qemu-trivial, qemu-devel
On 08/31/12 08:30, Fred Oliveira wrote:
> The check using INT_MAX (2147483647) is wrong in this case.
>
> Signed-off-by: Fred Oliveira <foliveira@cloudswitch.com>
> ---
> target-i386/cpu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 423e009..cbc172e 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -846,7 +846,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
> {
> X86CPU *cpu = X86_CPU(obj);
> const int64_t min = 0;
> - const int64_t max = INT_MAX;
> + const int64_t max = INT64_MAX;
> int64_t value;
>
> visit_type_int(v, &value, name, errp);
I think this a *trivial patch. Adding *qemu-trivial@nongnu.org.
-Don Slutz
**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-31 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-31 12:30 [Qemu-devel] [PATCH] target-i386: Allow tsc-frequency to be larger then 2.147G Fred Oliveira
2012-08-31 14:04 ` Don Slutz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).